Skip to content

JIT: Make async tail merging layout equality assert a check #128712

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jakobbotsch merged 3 commits into from
May 28, 2026
+7 −4
Merged

JIT: Make async tail merging layout equality assert a check #128712

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
782d0fb
Revert "JIT: Tail merge async suspensions (#128559)"
jakobbotsch May 28, 2026
edb9739
Reapply "JIT: Tail merge async suspensions (#128559)"
jakobbotsch May 28, 2026
6aa2fce
Just make it a check instead
jakobbotsch May 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions src/coreclr/jit/async.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1975,10 +1975,13 @@ bool AsyncTransformation::IsReusableSuspension(const AsyncState* state,
}
}

// At this point we expect both suspensions to agree on the live locals
// since they both join at the same point. So we only need to assert that
// the layouts match.
assert(ContinuationLayoutBuilder::Equals(*layoutBuilder, *state->Layout));
if (!ContinuationLayoutBuilder::Equals(*layoutBuilder, *state->Layout))
{
// TODO: We would expect liveness to match in tail positions here. But
// sometimes that isn't the case -- why not?
return false;
}

return true;
}

Expand Down
Loading