Remove dotnet/corert#3873 workarounds#128739
Merged
Merged
Conversation
Pull request dotnet#128384 is running into this. It might be the first time in a long time that we need to do generic lookups in a non-Ecma method body. I don't think there are legitimate reasons why we would still need to do this. CI will complain loudly if there still is something. We'll want to fix it.
Contributor
|
Tagging subscribers to this area: @agocke, @dotnet/ilc-contrib |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes IL scanner fallbacks that previously allowed compiler-generated/non-Ecma entities to lazily build vtable slices or generic dictionary layouts during compilation. The intended effect is to make scanner misses fail explicitly instead of silently relying on legacy workarounds.
Changes:
- Makes scanned vtable lookup require a precomputed slice for all types.
- Makes scanned dictionary layout lookup require a precomputed layout for all type/method owners, except entities forced back to lazy lookup handling.
Member
Author
|
/azp run runtime-nativeaot-outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
jakobbotsch
approved these changes
May 29, 2026
This was referenced May 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request #128384 is running into this. It might be the first time in a long time that we need to do generic lookups in a non-Ecma method body.
I don't think there are legitimate reasons why we would still need to do this. CI will complain loudly if there still is something. We'll want to fix it.