[Experiment] late fsub#128761
Closed
EgorBo wants to merge 1 commit into
Closed
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
github-actions
Bot
added
the
area-CodeGen-coreclr
Contributor
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds an experimental SSA-based late forward substitution pass to RyuJIT, running after VN copy propagation to replace single-use SSA local stores with their pure value trees and remove the now-dead store.
Changes:
- Adds
optLateForwardSuband statement-level substitution logic inforwardsub.cpp. - Wires the new phase into the optimization pipeline and phase list.
- Adds a debug config knob and a memory allocator kind for the pass.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
src/coreclr/jit/forwardsub.cpp |
Implements the late SSA-based forward substitution pass and legality checks. |
src/coreclr/jit/compiler.cpp |
Invokes the new phase after VN copy propagation. |
src/coreclr/jit/compiler.h |
Declares the new compiler phase helpers. |
src/coreclr/jit/compphases.h |
Registers the new phase name. |
src/coreclr/jit/jitconfigvalues.h |
Adds JitNoLateForwardSub debug configuration. |
src/coreclr/jit/compmemkind.h |
Adds CMK_ForwardSub for temporary pass allocations. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.