Fix FireEtXplatGCBulkRootStaticVar guard to use FEATURE_EVENTSOURCE_XPLAT#128782
Closed
Copilot wants to merge 2 commits into
Closed
Fix FireEtXplatGCBulkRootStaticVar guard to use FEATURE_EVENTSOURCE_XPLAT#128782Copilot wants to merge 2 commits into
Copilot wants to merge 2 commits into
Conversation
…PLAT The #else branch for HOST_UNIX would compile the FireEtXplat* call on non-browser Unix targets (macOS, Android) that don't define FEATURE_EVENTSOURCE_XPLAT, causing build failures since the PR changes the generated FireEtXplat* declarations to only exist under that feature flag. Use #elif defined(FEATURE_EVENTSOURCE_XPLAT) and fall back to ERROR_SUCCESS when neither Windows ETW nor LTTng/Xplat is available. Co-authored-by: pavelsavara <271576+pavelsavara@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix code issues related to FireEtXplat usage
Fix FireEtXplatGCBulkRootStaticVar guard to use FEATURE_EVENTSOURCE_XPLAT
May 29, 2026
This was referenced May 29, 2026
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
#elsebranch forHOST_UNIXunconditionally compiled theFireEtXplatGCBulkRootStaticVarcall on all Unix targets, but the PR #128745 changes generatedFireEtXplat*declarations to only exist underFEATURE_EVENTSOURCE_XPLAT. Non-browser Unix targets (macOS, Android, WASI) that don't define this feature flag would fail to build.#elseto#elif defined(FEATURE_EVENTSOURCE_XPLAT)withERROR_SUCCESSfallback when neither Windows ETW nor LTTng/Xplat is available*.cpp,*.h) insrc/coreclrfor otherFireEtXplatcall sites — this is the only one