JIT: Fix debug igDataSize assignment to use code size (so exclude gc vars)#128811
Open
BoyBaykiller wants to merge 1 commit into
Open
JIT: Fix debug igDataSize assignment to use code size (so exclude gc vars)#128811BoyBaykiller wants to merge 1 commit into
igDataSize assignment to use code size (so exclude gc vars)#128811BoyBaykiller wants to merge 1 commit into
Conversation
Contributor
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
Contributor
Author
|
@jakobbotsch PTAL. |
This was referenced May 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This random method (and other) tells us at that
igDatapoints to after the gc vars.runtime/src/coreclr/jit/emit.h
Lines 352 to 360 in f2d5042
More specifically it points to "addr of instruction descriptors". However the corresponding debug-only
igDataSizewas being assignedgswhich is the size of the entire IG (including gc vars). It should use code size (sz) instead.Fixes this assert I was hitting in #128536:
runtime/src/coreclr/jit/emit.cpp
Line 10081 in f2d5042