Detect URL-encoded CRLF (%0D%0A) in FtpWebRequest URI#128983
Draft
Copilot wants to merge 2 commits into
Draft
Conversation
Co-authored-by: MihaZupan <25307628+MihaZupan@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add support for URL encoded check for new line in FtpWebRequest
Detect URL-encoded CRLF (%0D%0A) in FtpWebRequest URI
Jun 4, 2026
Contributor
|
Tagging subscribers to this area: @karelz, @dotnet/ncl |
This was referenced Jun 4, 2026
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FtpWebRequestalready rejects URIs containing a literal\r\nwith a clearFormatException, but the URL-encoded form%0D%0Aslips past the check and fails later with a less informative exception — a common case when a stray CRLF from upstream parsing gets URL-encoded for safety.Changes
src/libraries/System.Net.Requests/src/System/Net/FtpWebRequest.cs: Extend the constructor's CRLF check to also match%0D%0Acase-insensitively, throwing the sameFormatException(net_ftp_no_newlines) up front.src/libraries/System.Net.Requests/tests/FtpWebRequestTest.cs: AddCtor_NewLineInUri_ThrowsFormatExceptiontheory covering literal\r\nand the%0D%0A/%0d%0a/%0D%0acasing variants.