Delete MapViewOfFile/test1 PAL test (uses removed FILE_FLAG_NO_BUFFERING)#129089
Merged
Conversation
…_BUFFERING Co-authored-by: jkotas <6668460+jkotas@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix undeclared identifier FILE_FLAG_NO_BUFFERING in PALTests
Delete MapViewOfFile/test1 PAL test (uses removed FILE_FLAG_NO_BUFFERING)
Jun 7, 2026
jkotas
approved these changes
Jun 7, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes the PALSuite filemapping_memmgt/MapViewOfFile/test1 test and its registrations from the PAL test build and runner manifests, so the PAL test suite no longer attempts to compile or run a test that depends on a removed PAL flag.
Changes:
- Deleted
filemapping_memmgt/MapViewOfFile/test1/MapViewOfFile.cpp(and the test directory). - Removed the test from PALSuite build inputs (
CMakeLists.txt) and from test enumeration lists (compilableTests.txt,paltestlist.txt). - Removed the test from the WASM harness disabled-pattern list (
wasm/index.html).
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/coreclr/pal/tests/palsuite/wasm/index.html | Drops the disabled-pattern entry for the removed test from the WASM harness. |
| src/coreclr/pal/tests/palsuite/paltestlist.txt | Removes the deleted test from the PAL test list. |
| src/coreclr/pal/tests/palsuite/filemapping_memmgt/MapViewOfFile/test1/MapViewOfFile.cpp | Deletes the obsolete test implementation. |
| src/coreclr/pal/tests/palsuite/compilableTests.txt | Removes the deleted test from the “compilable tests” list. |
| src/coreclr/pal/tests/palsuite/CMakeLists.txt | Stops building the deleted test as part of paltests. |
AaronRobinsonMSFT
approved these changes
Jun 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FILE_FLAG_NO_BUFFERINGwas removed from the PAL headers, causingMapViewOfFile/test1to fail to compile on all non-Windows platforms across 6+ CI legs.filemapping_memmgt/MapViewOfFile/test1/MapViewOfFile.cppand its directoryCMakeLists.txt,compilableTests.txt,paltestlist.txt, andwasm/index.html