Clean up S.S.AccessControl#129623
Open
vcsjones wants to merge 3 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR modernizes and de-noises System.Security.AccessControl implementation sources by removing legacy styling artifacts (regions, banner comments, excess separators/blank lines) and aligning parts of the code with current conventions, without intended behavioral changes.
Changes:
- Removed legacy
#regionblocks and decorative/banner comment noise across the AccessControl implementation files. - Simplified code formatting (blank lines/comment spacing) and removed redundant
this.qualifiers. - Renamed some internal/private fields in
Privilege.csto better match current naming conventions.
Show a summary per file
| File | Description |
|---|---|
| src/libraries/System.Security.AccessControl/src/System/Security/AccessControl/Win32.cs | Comment/whitespace cleanup around Win32 helper wrappers. |
| src/libraries/System.Security.AccessControl/src/System/Security/AccessControl/SecurityDescriptor.cs | Removed legacy banners/regions and tightened comment spacing; minor this. cleanup. |
| src/libraries/System.Security.AccessControl/src/System/Security/AccessControl/Rules.cs | Removed regions/blank lines; small cleanup inside AuthorizationRuleCollection. |
| src/libraries/System.Security.AccessControl/src/System/Security/AccessControl/Privilege.cs | Renamed a few fields and removed redundant this. qualifiers; tightened comment spacing. |
| src/libraries/System.Security.AccessControl/src/System/Security/AccessControl/ObjectSecurityT.cs | Removed legacy banners/regions and tightened spacing. |
| src/libraries/System.Security.AccessControl/src/System/Security/AccessControl/ObjectSecurity.cs | Removed legacy banners/regions and tightened spacing; minor this. cleanup. |
| src/libraries/System.Security.AccessControl/src/System/Security/AccessControl/NativeObjectSecurity.cs | Removed legacy banners/regions and tightened spacing; minor this. cleanup. |
| src/libraries/System.Security.AccessControl/src/System/Security/AccessControl/Enums.cs | Minor whitespace cleanup. |
| src/libraries/System.Security.AccessControl/src/System/Security/AccessControl/CommonObjectSecurity.cs | Comment cleanup and minor type-name simplification (Type vs System.Type). |
| src/libraries/System.Security.AccessControl/src/System/Security/AccessControl/ACL.cs | Large-scale comment/region/blank-line cleanup within ACL implementation. |
| src/libraries/System.Security.AccessControl/src/System/Security/AccessControl/ACE.cs | Large-scale comment/region/blank-line cleanup within ACE implementation. |
Copilot's findings
- Files reviewed: 11/11 changed files
- Comments generated: 4
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When S.S.AccessControl was ported much of it had a lot of code style that does not fit with the current coding standards.
#region/#endregionblocks.//separator lines.this.qualifiers.Privilege.csto match current field naming conventions.A lot of the cleanup mentioned in #15934 (comment) has already happened organically due to various analyzers and code fixers.
There should be no functional changes.
Fixes #15934