[experiment] fold definitely never instanceof casts#129891
Closed
EgorBo wants to merge 1 commit into
Closed
Conversation
Member
Author
|
@MihuBot -nuget |
Contributor
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a JIT assertion-propagation optimization to fold exact type tests (method-table comparisons) to constants when existing subtype/exact-type assertions prove the object can never be exactly the tested type, including across PHI reaching assertions.
Changes:
- Introduces
Compiler::optAssertionVNIsNotExactTypeto infer “never exactly this type” from subtype/exact-type assertions and PHI-reaching assertions. - Uses the new helper in
optAssertionPropGlobal_RelOpto foldIND(obj) ==/!= TypeHandleintofalse/truewhen provable. - Adds the helper declaration to
compiler.h.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/coreclr/jit/compiler.h | Declares the new optAssertionVNIsNotExactType assertion-prop helper. |
| src/coreclr/jit/assertionprop.cpp | Implements the helper and adds a new folding case in global relop assertion propagation for exact type tests. |
Comment on lines
+2586
to
+2591
| // We have "objVN is (exactly/subtype of) cls". If "exactCls" can never be cast to | ||
| // "cls", then objVN's exact runtime type can never be "exactCls". | ||
| if (info.compCompHnd->compareTypesForCast(exactCls, cls) == TypeCompareState::MustNot) | ||
| { | ||
| return true; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
just a ci test to get diffs.
Example of what it folds:
to no-op