Add public Property for VersionMadeBy flag in zipfiles#130109
Open
alinpahontu2912 wants to merge 3 commits into
Open
Add public Property for VersionMadeBy flag in zipfiles#130109alinpahontu2912 wants to merge 3 commits into
alinpahontu2912 wants to merge 3 commits into
Conversation
Contributor
|
Tagging subscribers to this area: @karelz, @dotnet/area-system-io-compression |
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a new public API on ZipArchiveEntry to expose the ZIP “version made by” field (two bytes: host platform + ZIP spec version) so callers can inspect the original metadata from the central directory.
Changes:
- Add
ZipArchiveEntry.VersionMadeBy(publicushort,[CLSCompliant(false)]) computed from the stored “made by” platform/spec fields. - Update the
System.IO.Compressionref assembly to include the new public property.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/libraries/System.IO.Compression/src/System/IO/Compression/ZipArchiveEntry.cs | Adds the new VersionMadeBy public property and its XML documentation. |
| src/libraries/System.IO.Compression/ref/System.IO.Compression.cs | Exposes ZipArchiveEntry.VersionMadeBy in the reference assembly surface. |
Comment on lines
+334
to
+335
| [CLSCompliant(false)] | ||
| public ushort VersionMadeBy => (ushort)(((byte)_versionMadeByPlatform << 8) | (byte)_versionMadeBySpecification); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #124755