Fix marshalling null delegates#241
Merged
jkotas merged 3 commits intodotnet:masterfrom Nov 25, 2019
MichalStrehovsky:fixDelegate
Merged
Fix marshalling null delegates#241jkotas merged 3 commits intodotnet:masterfrom MichalStrehovsky:fixDelegate
jkotas merged 3 commits intodotnet:masterfrom
MichalStrehovsky:fixDelegate
Conversation
Null delegates marshal as null pointers and vice versa.
jkotas
reviewed
Nov 24, 2019
|
|
||
| codeStream.EmitLabel(lNullPointer); | ||
|
|
||
| StoreNativeValue(codeStream); |
Member
There was a problem hiding this comment.
StoreNativeValue expects value of the right type on the IL stack. We do not have value of the right type on the IL stack here for the null case.
Member
Author
There was a problem hiding this comment.
Sigh, wanted to avoid the branching dance so hard I missed this...
jkotas
approved these changes
Nov 25, 2019
ghost
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Null delegates marshal as null pointers and vice versa.
Found on the CoreRT side. Didn't try looking for test coverage here.