Fix BeginSendRequest and EndSendRequest on LdapConnection#37774
Merged
Fix BeginSendRequest and EndSendRequest on LdapConnection#37774
Conversation
stephentoub
reviewed
Jun 11, 2020
Member
Author
|
Unfortunately the APM async methods can't be easily tested with our UnitTests without using an actual LDAP server, but I have ran them locally against one in all Windows, Linux and OSX and they all work now using APM methods. |
stephentoub
approved these changes
Jun 12, 2020
Member
Author
|
Merging since the two test runs that are timing out are unrelated to this PR. Thanks for the help with this @stephentoub |
ghost
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #36690
cc: @tarekgh @stephentoub
LdapConnection had Async APM methods that never really worked in .NET Core as they were using Delegate.BeginInvoke and Delegate.EndInvoke which are not supported in .NET Core. These changes will make it so that they don't use that anymore and instead use Tasks and polling in order to not block a thread in the threadpool.
FYI: @blowdart @Tratcher @JunTaoLuo