Bring back Microsoft.Bcl.AsyncInterfaces#40189
Merged
14 commits merged intodotnet:masterfrom Jul 31, 2020
Merged
Conversation
This is needed in order to build a version of this assembly that uses the latest version of its dependency System.Threading.Tasks.Extensions Without this, we'd reference in inconsistent set of versions for S.T.T.E in libraries that use both AsyncInterfaces and S.T.T.E.
Collaborator
|
Note regarding the This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change. |
Collaborator
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
ViktorHofer
reviewed
Jul 31, 2020
src/libraries/Microsoft.Bcl.AsyncInterfaces/ref/Microsoft.Bcl.AsyncInterfaces.csproj
Outdated
Show resolved
Hide resolved
ViktorHofer
reviewed
Jul 31, 2020
src/libraries/Microsoft.Bcl.AsyncInterfaces/ref/Microsoft.Bcl.AsyncInterfaces.csproj
Outdated
Show resolved
Hide resolved
ViktorHofer
reviewed
Jul 31, 2020
src/libraries/Microsoft.Bcl.AsyncInterfaces/src/Microsoft.Bcl.AsyncInterfaces.csproj
Outdated
Show resolved
Hide resolved
ViktorHofer
reviewed
Jul 31, 2020
src/libraries/Microsoft.Bcl.AsyncInterfaces/src/Microsoft.Bcl.AsyncInterfaces.csproj
Outdated
Show resolved
Hide resolved
ViktorHofer
reviewed
Jul 31, 2020
ViktorHofer
reviewed
Jul 31, 2020
src/libraries/Microsoft.Extensions.Logging/src/Microsoft.Extensions.Logging.csproj
Outdated
Show resolved
Hide resolved
ViktorHofer
reviewed
Jul 31, 2020
...Microsoft.Extensions.Logging.EventSource/src/Microsoft.Extensions.Logging.EventSource.csproj
Outdated
Show resolved
Hide resolved
ViktorHofer
reviewed
Jul 31, 2020
...braries/Microsoft.Extensions.Logging.Console/src/Microsoft.Extensions.Logging.Console.csproj
Outdated
Show resolved
Hide resolved
ViktorHofer
reviewed
Jul 31, 2020
src/libraries/Microsoft.Extensions.Hosting/src/Microsoft.Extensions.Hosting.csproj
Outdated
Show resolved
Hide resolved
ViktorHofer
reviewed
Jul 31, 2020
...crosoft.Extensions.Hosting.Abstractions/src/Microsoft.Extensions.Hosting.Abstractions.csproj
Outdated
Show resolved
Hide resolved
ViktorHofer
reviewed
Jul 31, 2020
...Microsoft.Extensions.DependencyInjection/src/Microsoft.Extensions.DependencyInjection.csproj
Outdated
Show resolved
Hide resolved
ViktorHofer
reviewed
Jul 31, 2020
src/libraries/Microsoft.Bcl.AsyncInterfaces/tests/Microsoft.Bcl.AsyncInterfaces.Tests.csproj
Outdated
Show resolved
Hide resolved
…AsyncInterfaces.csproj
…AsyncInterfaces.csproj
…AsyncInterfaces.csproj
…AsyncInterfaces.csproj
…sions.Logging.csproj
…rosoft.Extensions.Logging.EventSource.csproj
…ft.Extensions.Logging.Console.csproj
…sions.Hosting.csproj
…crosoft.Extensions.Hosting.Abstractions.csproj
…rosoft.Extensions.DependencyInjection.csproj
…l.AsyncInterfaces.Tests.csproj
ViktorHofer
reviewed
Jul 31, 2020
src/libraries/Microsoft.Bcl.AsyncInterfaces/src/Microsoft.Bcl.AsyncInterfaces.csproj
Outdated
Show resolved
Hide resolved
…AsyncInterfaces.csproj
ViktorHofer
approved these changes
Jul 31, 2020
Member
ViktorHofer
left a comment
ViktorHofer
left a comment
There was a problem hiding this comment.
Thanks for bringing this back so promptly. We should also follow-up on the msbuild side by updating to a later version.
I fixed the build (replaced TargetGroup with TargetFramework, removed default references, and P2P the src project where it should, to get the copy-local assets).
Member
Author
|
Thanks for cleaning up the cruft that I missed when bringing back these old projects. I've pulled the changes locally, built privates, applied them to SDK repo, and confirmed it fixed the issue. |
|
Hello @ericstj! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
ghost
merged commit
NTaylorMullen
pushed a commit
to dotnet/aspnetcore
that referenced
this pull request
Aug 3, 2020
…of DependencyInjection. - This was introduced as part of: dotnet/runtime#40189 - Prior to this we'd get version conflicts for our referenced Bcl.AsyncInterfaces.
dougbu
pushed a commit
to dotnet/aspnetcore
that referenced
this pull request
Aug 6, 2020
* React to SDK changes
* Skip instead of quar
* Rely on transitive Microsoft.Bcl.AsyncInterfaces since it's now part of DependencyInjection.
- This was introduced as part of: dotnet/runtime#40189
- Prior to this we'd get version conflicts for our referenced Bcl.AsyncInterfaces.
* Update global.json
- move to RC1 SDK
* React to runtime nullability changes with DataAnnotations.
- ValidationResult was updated to declare its nullability: dotnet/runtime@a9009db#diff-8e86bc8fee3eb0242c5b8368dfabe065
* Stop using HttpRequestMessage.Properties in favor of non-obsoleted HttpRequestMessage.Options.
- Introduced in dotnet/runtime@3eda592
* Stop using more HttpRequestMessage.Properties in Component's web assembly project.
- Introduced in dotnet/runtime@3eda592
* Update dependencies from https://github.com/dotnet/runtime build 20200804.16
System.ComponentModel.Annotations , System.Diagnostics.DiagnosticSource , System.Diagnostics.EventLog , Microsoft.Extensions.Logging , Microsoft.Extensions.Logging.Abstractions , Microsoft.Extensions.Logging.Configuration , Microsoft.Extensions.Logging.Console , Microsoft.Extensions.Logging.Debug , Microsoft.Extensions.Logging.EventLog , Microsoft.Extensions.Logging.EventSource , Microsoft.Extensions.Logging.TraceSource , Microsoft.Extensions.Options , Microsoft.Extensions.Options.ConfigurationExtensions , Microsoft.Extensions.Options.DataAnnotations , Microsoft.Extensions.Primitives , Microsoft.Extensions.Internal.Transport , Microsoft.Extensions.Http , Microsoft.Extensions.Hosting , Microsoft.Extensions.Caching.Abstractions , Microsoft.Extensions.Caching.Memory , Microsoft.Extensions.Configuration , Microsoft.Extensions.Configuration.Abstractions , Microsoft.Extensions.Configuration.Binder , Microsoft.Extensions.Configuration.CommandLine , Microsoft.Extensions.Configuration.EnvironmentVariables , Microsoft.Extensions.Configuration.FileExtensions , Microsoft.Extensions.Configuration.Ini , Microsoft.Extensions.Configuration.Json , Microsoft.Extensions.Configuration.UserSecrets , Microsoft.Extensions.Configuration.Xml , Microsoft.Extensions.DependencyInjection , Microsoft.Extensions.DependencyInjection.Abstractions , Microsoft.Extensions.DependencyModel , Microsoft.Extensions.FileProviders.Abstractions , Microsoft.Extensions.FileProviders.Composite , Microsoft.Extensions.FileProviders.Physical , Microsoft.Extensions.FileSystemGlobbing , Microsoft.Extensions.HostFactoryResolver.Sources , Microsoft.Extensions.Hosting.Abstractions , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.Platforms , Microsoft.Win32.Registry , Microsoft.Win32.SystemEvents , Microsoft.NETCore.App.Internal , Microsoft.NETCore.App.Ref , System.Drawing.Common , System.Text.Encodings.Web , System.Text.Json , System.Threading.Channels , System.Windows.Extensions , System.ServiceProcess.ServiceController , System.Security.Principal.Windows , System.IO.Pipelines , System.Net.Http.Json , System.Net.Http.WinHttpHandler , System.Net.WebSockets.WebSocketProtocol , System.Reflection.Metadata , System.Resources.Extensions , System.Runtime.CompilerServices.Unsafe , System.Security.AccessControl , System.Security.Cryptography.Cng , System.Security.Cryptography.Pkcs , System.Security.Cryptography.Xml , System.Security.Permissions
From Version 5.0.0-rc.1.20370.4 -> To Version 5.0.0-rc.1.20404.16
* Ignitor to 5.0
* Constants
* Update dependencies from https://github.com/dotnet/efcore build 20200805.3
Microsoft.EntityFrameworkCore.Tools , Microsoft.EntityFrameworkCore.SqlServer , dotnet-ef , Microsoft.EntityFrameworkCore , Microsoft.EntityFrameworkCore.Relational , Microsoft.EntityFrameworkCore.Sqlite , Microsoft.EntityFrameworkCore.InMemory
From Version 5.0.0-rc.1.20372.13 -> To Version 5.0.0-rc.1.20405.3
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Co-authored-by: Pranav K <prkrishn@hotmail.com>
Co-authored-by: wtgodbe <wigodbe@microsoft.com>
Co-authored-by: N. Taylor Mullen <nimullen@microsoft.com>
Co-authored-by: Justin Kotalik <jukotali@microsoft.com>
Jacksondr5
pushed a commit
to Jacksondr5/runtime
that referenced
this pull request
Aug 10, 2020
* Bring back Microsoft.Bcl.AsyncInterfaces This is needed in order to build a version of this assembly that uses the latest version of its dependency System.Threading.Tasks.Extensions Without this, we'd reference in inconsistent set of versions for S.T.T.E in libraries that use both AsyncInterfaces and S.T.T.E. * Update src/libraries/Microsoft.Bcl.AsyncInterfaces/ref/Microsoft.Bcl.AsyncInterfaces.csproj * Update src/libraries/Microsoft.Bcl.AsyncInterfaces/ref/Microsoft.Bcl.AsyncInterfaces.csproj * Update src/libraries/Microsoft.Bcl.AsyncInterfaces/src/Microsoft.Bcl.AsyncInterfaces.csproj * Update src/libraries/Microsoft.Bcl.AsyncInterfaces/src/Microsoft.Bcl.AsyncInterfaces.csproj * Update src/libraries/System.Text.Json/src/System.Text.Json.csproj * Update src/libraries/Microsoft.Extensions.Logging/src/Microsoft.Extensions.Logging.csproj * Update src/libraries/Microsoft.Extensions.Logging.EventSource/src/Microsoft.Extensions.Logging.EventSource.csproj * Update src/libraries/Microsoft.Extensions.Logging.Console/src/Microsoft.Extensions.Logging.Console.csproj * Update src/libraries/Microsoft.Extensions.Hosting/src/Microsoft.Extensions.Hosting.csproj * Update src/libraries/Microsoft.Extensions.Hosting.Abstractions/src/Microsoft.Extensions.Hosting.Abstractions.csproj * Update src/libraries/Microsoft.Extensions.DependencyInjection/src/Microsoft.Extensions.DependencyInjection.csproj * Update src/libraries/Microsoft.Bcl.AsyncInterfaces/tests/Microsoft.Bcl.AsyncInterfaces.Tests.csproj * Update src/libraries/Microsoft.Bcl.AsyncInterfaces/src/Microsoft.Bcl.AsyncInterfaces.csproj Co-authored-by: Viktor Hofer <viktor.hofer@microsoft.com>
joperezr
reviewed
Aug 10, 2020
Member
joperezr
left a comment
joperezr
left a comment
There was a problem hiding this comment.
LGTM. That said, isn't this something we could have fixed in servicing? or is this because S.T.T.E still being built?
ghost
locked as resolved and limited conversation to collaborators
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is needed in order to build a version of this assembly that uses
the latest version of its dependency System.Threading.Tasks.Extensions
Without this, we'd reference in inconsistent set of versions for S.T.T.E
in libraries that use both AsyncInterfaces and S.T.T.E.