[release/5.0] Fix issue 41413#41672
Merged
PeterSolMS merged 1 commit intodotnet:release/5.0from Sep 1, 2020
Merged
Conversation
|
Tagging subscribers to this area: @dotnet/gc |
PeterSolMS
changed the title
jeffschwMSFT
approved these changes
Sep 1, 2020
Member
jeffschwMSFT
left a comment
jeffschwMSFT
left a comment
There was a problem hiding this comment.
Approved. Once we get a clean CI we can merge.
ghost
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #41445 to release/5.0
/cc @PeterSolMS
Customer Impact
This fixes a rare AV when GC.GetTotalMemory executes at the same time as background GC deletes the ephemeral segment.
Testing
Repro case supplied by Chris Ahna now executes without crashing, CI tests.
Risk
Low - the change is small and fixes the rare AV.
Doing this backport PR by hand because of issues with commit history.