[release/5.0-rc2] [wasm][debugger] Fix stepping out from an async method#42263
Merged
lewing merged 4 commits intorelease/5.0-rc2from Sep 22, 2020
Merged
[release/5.0-rc2] [wasm][debugger] Fix stepping out from an async method#42263lewing merged 4 commits intorelease/5.0-rc2from
lewing merged 4 commits intorelease/5.0-rc2from
Conversation
github-actions
bot
requested review from
CoffeeFlux,
SamMonoRT,
lambdageek,
thaystg and
vargaz
as code owners
|
Tagging subscribers to this area: @thaystg |
lewing
added
Servicing-approved
ghost
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #42227 to release/5.0-rc2
/cc @thaystg
Customer Impact
Fixes #41973. Avoids a potential assertion in the WASM runtime when stepping over an async method in the debugger by sharing some code with the desktop debugger.
Testing
Unit tests and tested manually.
Risk
Low. Mostly reusing existing code to improve the behavior.