Skip to content

[release/5.0-rc2] Sign CrossOSDiag packages even with post-build signing#42688

Merged
mmitche merged 4 commits intodotnet:release/5.0-rc2from
mmitche:sign-those-cross-os-dac-packages
Sep 24, 2020
Merged

[release/5.0-rc2] Sign CrossOSDiag packages even with post-build signing#42688
mmitche merged 4 commits intodotnet:release/5.0-rc2from
mmitche:sign-those-cross-os-dac-packages

Conversation

@mmitche
Copy link
Copy Markdown
Member

@mmitche mmitche commented Sep 24, 2020

Also change over to using 2019 Pool for the leg.

@ghost
Copy link
Copy Markdown

ghost commented Sep 24, 2020

Tagging subscribers to this area: @tommcdon
See info in area-owners.md if you want to be subscribed.

@mmitche mmitche changed the title Sign CrossOSDiag packages even with post-build signing [release/5.0-rc2] Sign CrossOSDiag packages even with post-build signing Sep 24, 2020
@mmitche mmitche requested a review from hoyosjs September 24, 2020 16:46
@mmitche
Copy link
Copy Markdown
Member Author

mmitche commented Sep 24, 2020

Official build with these changes: https://dev.azure.com/dnceng/internal/_build/results?buildId=829388&view=results

@mmitche mmitche merged commit e48e542 into dotnet:release/5.0-rc2 Sep 24, 2020
@runfoapp runfoapp bot mentioned this pull request Sep 30, 2020
Open
mmitche added a commit that referenced this pull request Nov 11, 2020
@mmitche
Add signing information to asset manifest (port #41889 and #42688) (#…
905a367 
…43896)

* Post build signing

* Add PostBuildSign flag
@ghost ghost locked as resolved and limited conversation to collaborators Dec 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@hoyosjs hoyosjs hoyosjs approved these changes

Assignees

No one assigned

Labels

area-Diagnostics-coreclr

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mmitche @hoyosjs @Dotnet-GitSync-Bot