[release/5.0-rc2][wasm][debugger] Fixing step over in an async method#42699
Merged
lewing merged 1 commit intodotnet:release/5.0-rc2from Sep 25, 2020
Merged
[release/5.0-rc2][wasm][debugger] Fixing step over in an async method#42699lewing merged 1 commit intodotnet:release/5.0-rc2from
lewing merged 1 commit intodotnet:release/5.0-rc2from
Conversation
thaystg
requested review from
CoffeeFlux,
SamMonoRT,
lambdageek and
vargaz
as code owners
|
Tagging subscribers to this area: @thaystg |
lewing
added
Servicing-consider
ghost
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #42639 to release/5.0-rc2
/cc @thaystg
Fixes incorrect stack reporting when stepping in async methods in the WASM debugger.
Customer Impact
When a user is trying to step over an async method the line numbers shown in the call stack are wrong.
Testing
I test locally and @radical created two test case for it.
Risk
Very Low. Browser debugging specific and the check that is relaxed does not apply to the single threaded case.