Skip to content

Fix IL interpreter build on GCC.#44049

Merged
jkotas merged 1 commit intomasterfrom
unknown repository
Oct 31, 2020
Merged

Fix IL interpreter build on GCC.#44049
jkotas merged 1 commit intomasterfrom
unknown repository

Conversation

@heiher
Copy link
Copy Markdown
Contributor

@heiher heiher commented Oct 30, 2020

Build Command:

./build.sh clr -c debug -gcc -cmakeargs "-DFEATURE_INTERPRETER=1"
./build.sh clr -c release -gcc -cmakeargs "-DFEATURE_INTERPRETER=1"

Errors:

  /home/heiher/git/dotnet/runtime/src/coreclr/src/vm/interpreter.h:1041:35: error: extra qualification ‘Interpreter::’ on member ‘MethodHandleToInterpreterMethInfoPtr’ [-fpermissive]
   1041 |     static InterpreterMethodInfo* Interpreter::MethodHandleToInterpreterMethInfoPtr(CORINFO_METHOD_HANDLE md);

  /home/heiher/git/dotnet/runtime/src/coreclr/src/vm/interpreter.cpp:4922:23: error: comparison of integer expressions of different signedness: ‘unsigned int’ and ‘int’ [-Werror=sign-compare]
   4922 |         else if (val2 == -1 && val1 == static_cast<T>(((UINT64)1) << (sizeof(T)*8 - 1))) // min int / -1 is not representable.
        |                  ~~~~~^~~~~

  /home/heiher/git/dotnet/runtime/src/coreclr/src/vm/interpreter.cpp: In static member function ‘static bool Interpreter::MethodMayHaveLoop(BYTE*, unsigned int)’:
  /home/heiher/git/dotnet/runtime/src/coreclr/src/inc/debugmacros.h:45:14: error: this statement may fall through [-Werror=implicit-fallthrough=]
     45 |              if (!(expr)) {                                                 \
        |              ^~
  /home/heiher/git/dotnet/runtime/src/coreclr/src/inc/debugmacros.h:54:26: note: in expansion of macro ‘_ASSERTE_MSG’
     54 |   #define _ASSERTE(expr) _ASSERTE_MSG(expr, #expr)
        |                          ^~~~~~~~~~~~
  /home/heiher/git/dotnet/runtime/src/coreclr/src/vm/interpreter.cpp:3538:13: note: in expansion of macro ‘_ASSERTE’
   3538 |             _ASSERTE(op < CEE_COUNT);  // Bounds check for below.
        |             ^~~~~~~~
  /home/heiher/git/dotnet/runtime/src/coreclr/src/vm/interpreter.cpp:3540:9: note: here
   3540 |         default:
        |         ^~~~~~~

@jkotas @am11 Request for review please.

@ghost
Copy link
Copy Markdown

ghost commented Oct 30, 2020

Tagging subscribers to this area: @BrzVlad
See info in area-owners.md if you want to be subscribed.

@jkotas jkotas added area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI and removed area-Codegen-Interpreter-mono labels Oct 30, 2020
@am11
Copy link
Copy Markdown
Member

am11 commented Oct 31, 2020

LGTM. Tested your changes with clang, no issues.

@jkotas
Copy link
Copy Markdown
Member

jkotas commented Oct 31, 2020

Thanks!

@jkotas jkotas merged commit bb537d0 into dotnet:master Oct 31, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Dec 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants