Skip to content

Comments

Apple silicon debugger#47834

Merged
janvorli merged 5 commits intodotnet:masterfrom
sdmaclea:AppleSiliconDebugger
Feb 4, 2021
Merged

Apple silicon debugger#47834
janvorli merged 5 commits intodotnet:masterfrom
sdmaclea:AppleSiliconDebugger

Conversation

@sdmaclea
Copy link
Contributor

@sdmaclea sdmaclea commented Feb 4, 2021

No description provided.

@ghost
Copy link

ghost commented Feb 4, 2021

Tagging subscribers to this area: @tommcdon
See info in area-owners.md if you want to be subscribed.

Issue Details
Author: sdmaclea
Assignees: sdmaclea
Labels:

arch-arm64, area-Diagnostics-coreclr, os-mac-os-x-big-sur

Milestone: 6.0.0

if (pThread != NULL && g_pDebugInterface != NULL)
{
// On ARM and ARM64 Linux exception point to the break instruction.
#if (defined(TARGET_ARM) || defined(TARGET_ARM64))
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is in a TARGET_UNIX #ifdef. It needs to be enabled on MacOS & Linux. I am not aware of another Unix platform where it needs to be disabled.

Copy link
Member

@janvorli janvorli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@janvorli janvorli merged commit f818e29 into dotnet:master Feb 4, 2021
@sdmaclea sdmaclea deleted the AppleSiliconDebugger branch February 4, 2021 15:54
@ghost ghost locked as resolved and limited conversation to collaborators Mar 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants