Skip to content

Fix pointer tearing in JIT_MemSet helper on ARM64#50273

Merged
AntonLapounov merged 1 commit into
dotnet:mainfrom
jkotas:fix-49859
Mar 26, 2021
Merged

Fix pointer tearing in JIT_MemSet helper on ARM64#50273
AntonLapounov merged 1 commit into
dotnet:mainfrom
jkotas:fix-49859

Conversation

@jkotas
Copy link
Copy Markdown
Member

@jkotas jkotas commented Mar 26, 2021

Fixes #49859

@ghost ghost added the area-GC-coreclr label Mar 26, 2021
@ghost
Copy link
Copy Markdown

ghost commented Mar 26, 2021

Tagging subscribers to this area: @dotnet/gc
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #49859

Author: jkotas
Assignees: -
Labels:

area-GC-coreclr

Milestone: -

@jkotas
Copy link
Copy Markdown
Member Author

jkotas commented Mar 26, 2021

Root cause analysis in #49859 (comment).

This matches what we do on other platforms. It is not perfect since there is a theoretical chance that memset may tear pointers, but this will do for now.

Comment thread src/coreclr/vm/arm64/crthelpers.S
@mangod9
Copy link
Copy Markdown
Member

mangod9 commented Mar 26, 2021

@AntonLapounov as fyi.

@AntonLapounov AntonLapounov merged commit 1ce76dc into dotnet:main Mar 26, 2021
@sdmaclea
Copy link
Copy Markdown
Contributor

@jkotas Thanks

@jkotas jkotas deleted the fix-49859 branch April 1, 2021 05:01
Anipik pushed a commit that referenced this pull request Apr 6, 2021
@ghost ghost locked as resolved and limited conversation to collaborators May 1, 2021
@karelz karelz added this to the 6.0.0 milestone May 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Crash in GC on arm64

5 participants