Don't trim if MemoryCache is already empty.#51762
Merged
StephenMolloy merged 1 commit intodotnet:mainfrom May 6, 2021
Merged
Conversation
mconnew
reviewed
Apr 26, 2021
src/libraries/System.Runtime.Caching/src/System/Runtime/Caching/MemoryCacheStatistics.cs
Show resolved
Hide resolved
mconnew
approved these changes
Apr 30, 2021
drieseng
reviewed
May 23, 2021
| sw.Stop(); | ||
| // 1) don't update stats if the trim happend because MAX_COUNT was exceeded | ||
| // 2) don't update stats unless we removed at least one entry | ||
| if (percent > 0 && trimmedOrExpired > 0) |
Contributor
There was a problem hiding this comment.
(late to the game, but ...) any reason why you check percent again?
ghost
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Don't trim an empty MemoryCache
There exists the potential for an empty MemoryCache to
be trimmed under memory pressure. When this happens,
the result is a DivideByZero exception. The solution is to
not trim empty caches, since doing so doesn't make
any sense anyway.
Fix #1423