Add public Architecture enum value for s390x#52906
Merged
akoeplinger merged 1 commit intodotnet:mainfrom May 19, 2021
uweigand:s390x-architecture
Merged
Add public Architecture enum value for s390x#52906akoeplinger merged 1 commit intodotnet:mainfrom uweigand:s390x-architecture
akoeplinger merged 1 commit intodotnet:mainfrom
uweigand:s390x-architecture
Conversation
* Add S390x value to System.Runtime.InteropServices.Architecture enum * Add native s390x architecture detection
|
Note regarding the This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change. |
ghost
added
Member
I think you need to file an issue first and it has to go through API review |
Contributor
Author
Thanks! I've filed an issue now. |
Member
|
API was approved in #52909 |
akoeplinger
approved these changes
May 19, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add S390x value to System.Runtime.InteropServices.Architecture enum
Add native s390x architecture detection
Note to reviewers: This adds a new value to a publicly visible enum, so in that sense it affects the .NET API. I don't know if there are any special requirements when making such changes.