Merged
Conversation
… methods - Remove logic in MethodBuild that disallows static abstract methods - Add support in interface map for finding static virtuals, and enumerating them - Add tests
ghost
added
the
…ugging build time failures
trylek
approved these changes
May 19, 2021
| --target_os $(target_crossgen2_os) | ||
| --target_arch $(targetarch); | ||
| --target_arch $(targetarch) | ||
| --compiler_arch_os $(compiler_arch_os); |
Member
There was a problem hiding this comment.
Is the semicolon appropriate here?
Member
Author
There was a problem hiding this comment.
Yes. Its the separator between different commands in bash. Just like the '&' for cmd scripts below.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There were several problems with running these tests
There remains some evidence that the behavior is still a bit flaky, but the last test pass was completely green.