Merged
Conversation
Contributor
Author
|
PTAL @BruceForstall @dotnet/jit-contrib |
BruceForstall
suggested changes
May 19, 2021
Contributor
BruceForstall
left a comment
There was a problem hiding this comment.
I'm in favor of this.
I think you should add the new headers to JIT_HEADERS in CMakeLists.txt
Contributor
Author
done |
BruceForstall
approved these changes
May 19, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before:


After:
So now you don't need to memorize the order of the platforms in the target.t (note that the memorization did not help if there were more than 1 define for some platform, like on the screen).
That was a long time on my TODO list but I always wanted to do it like:
so we have comments in one place, but looks like I would not have time for it any time soon, so let's just cut it into pieces.
and small additional changes:
57d0580: C_ASSERT is not used there.
e3f5685: delete unused "REGNUM_MASK'.
e876ff0: delete redefines of "REGMASK_BITS".