Add better description of what to pass to hostfxr_initialize_for_dotnet_command_line#53678
Merged
vitek-karas merged 3 commits intodotnet:mainfrom Jun 4, 2021
Merged
Conversation
vitek-karas
added
documentation
|
Tagging subscribers to this area: @vitek-karas, @agocke, @VSadov Issue Details
|
elinor-fung
approved these changes
Jun 3, 2021
Member
elinor-fung
left a comment
elinor-fung
left a comment
There was a problem hiding this comment.
Do we want to update the header doc too? It mentions not supporting SDK commands, but the example might be helpful there too, since we do ship that header in our packs.
runtime/src/native/corehost/hostfxr.h
Line 104 in 0fcd769
AaronRobinsonMSFT
approved these changes
Jun 4, 2021
Co-authored-by: Elinor Fung <elfung@microsoft.com>
Member
Author
|
This change only modifies a comment, so the test failure is definitely not related. Filed #53720 to track it. |
ghost
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.