[release/6.0] Avoid issuing connection attempts for already cancelled requests#67226
Merged
carlossanlop merged 1 commit intodotnet:release/6.0from Apr 13, 2022
Merged
Conversation
…net#66992) * Avoid issuing connection attempts for already canceled requests * Cancelled => Canceled * Guard SocketsHttpHandler tests under SocketsHttpHandler.IsSupported
|
Tagging subscribers to this area: @dotnet/ncl Issue DetailsFixes #66990 Customer ImpactGreatly reduce the amount of work & time needed to process already-canceled requests when no connections are available. TestingAdded a targeted test case for the new behavior. RiskLow -- small change affecting only already-canceled requests.
|
ManickaP
approved these changes
Mar 28, 2022
Member
Author
|
CI failures are unrelated to this change:
|
leecow
added
Servicing-approved
This was referenced Apr 19, 2022
ghost
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #66990
Backport of #66992 to release/6.0
Customer Impact
Discovered when analyzing Dynamics memory leak when upgrading .NET Core 3.1 to 6.0 - see details in #66673 (comment).
Reduces the chance of a memory leak if an endpoint becomes unresponsive and new connections can't be established.
Greatly reduces the amount of work & time needed to process already-cancelled requests when no connections are available.
Testing
Added a targeted test case for the new behavior.
We have existing test coverage to ensure nothing regressed.
Risk
Low -- small change affecting only already-canceled requests.