Skip to content

[release/7.0-preview6] Add annotations for ref fields to public API surface#71266

Merged
carlossanlop merged 1 commit intorelease/7.0-preview6from
backport/pr-71265-to-release/7.0-preview6
Jun 24, 2022
Merged

[release/7.0-preview6] Add annotations for ref fields to public API surface#71266
carlossanlop merged 1 commit intorelease/7.0-preview6from
backport/pr-71265-to-release/7.0-preview6

Conversation

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented Jun 24, 2022

Backport of #71265 to release/7.0-preview6

/cc @AaronRobinsonMSFT

Customer Impact

This work adds new C# annotations to APIs that will be impacted in C# 11 (that is, ref fields). The goal here is for C# 11 to have the ref field support and for users to be able to use Preview 6 with the new language features. This ensures the Preview 6 ref pack is consumable with this language feature.

/cc @cston @stephentoub @jaredpar @jeffschwMSFT

@ghost
Copy link

ghost commented Jun 24, 2022

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@ghost
Copy link

ghost commented Jun 24, 2022

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@AaronRobinsonMSFT AaronRobinsonMSFT added the Servicing-consider Issue for next servicing release review label Jun 24, 2022
Copy link
Member

@jeffschwMSFT jeffschwMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. We will take for consideration in preview 6

Copy link
Member

@stephentoub stephentoub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming this is enough to unblock the compiler being ingested for P6, LGTM. We'll revisit exactly where/how we want to use scoped in main for P7.

@jeffschwMSFT jeffschwMSFT added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Jun 24, 2022
@jeffschwMSFT jeffschwMSFT added this to the 7.0.0 milestone Jun 24, 2022
@jeffschwMSFT
Copy link
Member

@carlossanlop this is ready when the branch is ready.

@carlossanlop carlossanlop merged commit d3fa592 into release/7.0-preview6 Jun 24, 2022
@carlossanlop carlossanlop deleted the backport/pr-71265-to-release/7.0-preview6 branch June 24, 2022 22:57
@ghost ghost locked as resolved and limited conversation to collaborators Jul 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants