Avoid a couple theoretical reorderings in ManualResetValueTaskSourceCore#72657
Merged
stephentoub merged 1 commit intodotnet:mainfrom Jul 27, 2022
Merged
Avoid a couple theoretical reorderings in ManualResetValueTaskSourceCore#72657stephentoub merged 1 commit intodotnet:mainfrom
stephentoub merged 1 commit intodotnet:mainfrom
Conversation
In a typical usage sequence, GetStatus is called and then GetResult is called. If the read of _result in GetResult could move to before the read of _continuation in GetStatus, then there could be a race condition where _result is read prior to it being written, then _continuation is set as part of the operation completing, and the implementation ends up returning an erroneous result. Similarly, in SignalCompletion, if the read of _continuationState could moved to before the first read of _continuation, it could be stale.
|
Tagging subscribers to this area: @mangod9 Issue DetailsIn a typical usage sequence, GetStatus is called and then GetResult is called. If the read of _result in GetResult could move to before the read of _continuation in GetStatus, then there could be a race condition where _result is read prior to it being written, then _continuation is set as part of the operation completing, and the implementation ends up returning an erroneous result. Similarly, in SignalCompletion, if the read of _continuationState could moved to before the first read of _continuation, it could be stale. Closes #68623
|
Member
Author
mangod9
approved these changes
Jul 27, 2022
timcassell
added a commit
to timcassell/BenchmarkDotNet
that referenced
this pull request
Jul 27, 2022
ghost
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In a typical usage sequence, GetStatus is called and then GetResult is called. If the read of _result in GetResult could move to before the read of _continuation in GetStatus, then there could be a race condition where _result is read prior to it being written, then _continuation is set as part of the operation completing, and the implementation ends up returning an erroneous result. Similarly, in SignalCompletion, if the read of _continuationState could moved to before the first read of _continuation, it could be stale.
Closes #68623