Skip to content

Fix BeginReceiveMessageFromV4BoundToSpecificV6_NotReceived #83463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
antonfirsov merged 5 commits into from
Apr 6, 2023
Merged

Fix BeginReceiveMessageFromV4BoundToSpecificV6_NotReceived #83463

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a1f8ace
BeginReceiveMessageFromV4BoundToSpecificV6_NotReceived -> BeginReceiv…
antonfirsov Mar 15, 2023
2eb0131
try Windows/Unix distinction
antonfirsov Mar 16, 2023
4c6000f
run ArgumentException variants only on Linux+Android,
antonfirsov Mar 16, 2023
c6b674e
oops
antonfirsov Mar 17, 2023
fa2390f
fix comment
antonfirsov Mar 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions src/libraries/System.Net.Sockets/tests/FunctionalTests/DualModeSocketTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1432,8 +1432,7 @@ public void BeginReceiveMessageFromV6BoundToSpecificV4_NotReceived()
}

[Fact]
[SkipOnPlatform(TestPlatforms.Linux | TestPlatforms.OSX | TestPlatforms.MacCatalyst | TestPlatforms.iOS | TestPlatforms.tvOS, "Expected behavior is different on Apple platforms and Linux")]
[ActiveIssue("https://github.com/dotnet/runtime/issues/81946", TestPlatforms.Android)]
[PlatformSpecific(TestPlatforms.Windows)] // Expected behavior is different on Apple platforms and Linux
public void BeginReceiveMessageFromV4BoundToSpecificV6_NotReceived()
{
Assert.Throws<TimeoutException>(() =>
Expand All @@ -1450,7 +1449,7 @@ public void BeginReceiveMessageFromV4BoundToSpecificV6_NotReceived()
// an acceptable difference due to the extra state that would otherwise
// be necessary to emulate the Winsock behavior.
[Fact]
[PlatformSpecific(TestPlatforms.Linux)] // Read the comment above
[PlatformSpecific(TestPlatforms.Linux | TestPlatforms.Android)] // Read the comment above
public void BeginReceiveMessageFromV4BoundToSpecificV6_NotReceived_Linux()
{
AssertExtensions.Throws<ArgumentException>("remoteEP", () =>
Expand Down Expand Up @@ -1606,8 +1605,7 @@ public void ReceiveMessageFromAsyncV6BoundToSpecificV4_NotReceived()
}

[Fact]
[SkipOnPlatform(TestPlatforms.Linux | TestPlatforms.OSX | TestPlatforms.MacCatalyst | TestPlatforms.iOS | TestPlatforms.tvOS, "Expected behavior is different on Apple platforms and Linux")]
[ActiveIssue("https://github.com/dotnet/runtime/issues/81946", TestPlatforms.Android)]
[PlatformSpecific(TestPlatforms.Windows)] // Expected behavior is different on Apple platforms and Linux
public void ReceiveMessageFromAsyncV4BoundToSpecificV6_NotReceived()
{
Assert.Throws<TimeoutException>(() =>
Expand All @@ -1624,7 +1622,7 @@ public void ReceiveMessageFromAsyncV4BoundToSpecificV6_NotReceived()
// an acceptable difference due to the extra state that would otherwise
// be necessary to emulate the Winsock behavior.
[Fact]
[PlatformSpecific(TestPlatforms.Linux)] // Read the comment above
[PlatformSpecific(TestPlatforms.Linux | TestPlatforms.Android)] // Read the comment above
public void ReceiveMessageFromAsyncV4BoundToSpecificV6_NotReceived_Linux()
{
AssertExtensions.Throws<ArgumentException>("remoteEP", () =>
Expand Down