Remove STJ dependency on IncrementalValuesProvider.Collect() #86616
Conversation
ghost
added
the
|
Tagging subscribers to this area: @dotnet/area-system-text-json, @gregsdennis Issue DetailsAddresses the last outstanding issue from #68353, namely
Slightly refactors the
|
|
|
||
| namespace System.Text.Json.SourceGeneration | ||
| { | ||
| public sealed partial class JsonSourceGenerator |
There was a problem hiding this comment.
Moves the Diagnostic descriptors to a standalone file for easier access.
| JsonSourceGenerationMode generationMode, | ||
| CancellationToken cancellationToken) | ||
| { | ||
| IEnumerable<SyntaxNode> attributeArguments = attributeSyntax.DescendantNodes().Where(node => node is AttributeArgumentSyntax); |
There was a problem hiding this comment.
Logic moved to ParseJsonSerializableAttribute
|
|
||
| List<ContextGenerationSpec>? contextGenSpecList = null; | ||
|
|
||
| foreach (IGrouping<SyntaxTree, ClassDeclarationSyntax> group in classDeclarationSyntaxList.GroupBy(c => c.SyntaxTree)) |
There was a problem hiding this comment.
This grouping was originally included to amortise the cost of the expensive compilation.GetSemanticModel method. However the semantic model is provided to us by the source generator context types, so calling the method is not actually necessary.
src/libraries/System.Text.Json/gen/JsonSourceGenerator.Parser.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Text.Json/gen/JsonSourceGenerator.Parser.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Text.Json/gen/JsonSourceGenerator.Roslyn3.11.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Text.Json/gen/JsonSourceGenerator.Roslyn4.0.cs
Outdated
Show resolved
Hide resolved
7 participants
Addresses the last outstanding issue from #68353, namely
Slightly refactors the
ParserandEmitterclasses so that they can be used with singularJsonSerializerContextdeclarations, allowing the incremental generator to generate source code for each of its inputs independently and on-demand.Fix #68353.