Fix diagnostic creation to ensure including the URI#91123
Merged
tarekgh merged 2 commits intodotnet:mainfrom Aug 25, 2023
Merged
Fix diagnostic creation to ensure including the URI#91123tarekgh merged 2 commits intodotnet:mainfrom
tarekgh merged 2 commits intodotnet:mainfrom
Conversation
|
Tagging subscribers to this area: @dotnet/area-extensions-logging Issue DetailsThe creation of
|
Member
|
This looks good, I just noticed one other instance of the same problem in d303781. @jkoritzinsky did you want to handle that separately, or would it make sense to add to this PR? |
Member
Author
|
@jkoritzinsky @ericstj I added the fix of the interop one too. |
jkoritzinsky
approved these changes
Aug 25, 2023
This was referenced Aug 25, 2023
Member
Author
|
/backport to release/8.0 |
Contributor
|
Started backporting to release/8.0: https://github.com/dotnet/runtime/actions/runs/5981087443 |
ghost
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The creation of
LoggingUnsupportedLanguageVersionin logging source gen was missing the URI link. The fix is to use the Create helper method to ensure adding the URI to the diagnostics.