fix locale-sensitive comparison of UnmatchedArgument error strings #29746
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Amaury Levé <amaury.leve@gmail.com>
…f format string and check for ordered presence of those in the formatted message.
Adds a helper method for setting culture to the test framework, driven from a shared reference to the hard-coded UI environment variable.
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
baronfel
added
Area-CLI
cli-ux
dsplaisted
approved these changes
Jan 4, 2023
Member
dsplaisted
left a comment
dsplaisted
left a comment
There was a problem hiding this comment.
Looks good, same feedback as on the other version of this PR.
Co-authored-by: Daniel Plaisted <dsplaisted@gmail.com>
Member
Author
|
Applied your suggested change on that other PR and cherry-picked it here as well 👍 |
Member
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
Author
|
Template engine leg is failing due to the moduleinitializer issue. @dotnet/templating-engine-maintainers how should I resolve this? did the moduleinitializer fixes get into 7.0.2xx? |
Member
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forward-port of #29559 to the 7.0.2xx release branch so that we don't miss the merge window.