Skip to content

Default container image tags to latest instead of versions #33132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 21, 2023
Merged

Default container image tags to latest instead of versions #33132

merged 1 commit into from
Jun 21, 2023

Conversation

@baronfel
Copy link
Member

@baronfel baronfel commented Jun 9, 2023

This is to make dev inner-loop and onboarding experiences better.

Closes dotnet/sdk-container-builds#458.

@ghost ghost added the untriaged Request triage from a team member label Jun 9, 2023
@ghost
Copy link

ghost commented Jun 9, 2023

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@baronfel baronfel added Area-Containers Related to dotnet SDK containers functionality and removed untriaged Request triage from a team member labels Jun 9, 2023
@build-analysis build-analysis bot mentioned this pull request Jun 9, 2023
Open
5 tasks
@baronfel baronfel changed the base branch from release/7.0.4xx to main June 9, 2023 13:57
@baronfel baronfel force-pushed the containers-default-to-latest branch from 1558b43 to 9c4bbee Compare June 9, 2023 14:02
@baronfel
Copy link
Member Author

baronfel commented Jun 9, 2023

Reset this pr to target main because it is a breaking change in container tag inference, so we should not break that mid-cycle

@baronfel
Default container image tags to latest instead of versions
c00e7f6 
This is to make dev inner-loop and onboarding experiences better.

Closes dotnet/sdk-container-builds#458.
@baronfel baronfel force-pushed the containers-default-to-latest branch from 9c4bbee to c00e7f6 Compare June 9, 2023 15:44
@baronfel baronfel marked this pull request as ready for review June 10, 2023 03:25
@baronfel baronfel requested a review from a team as a code owner June 10, 2023 03:25
@baronfel baronfel mentioned this pull request Jun 12, 2023
Closed
@MichalPavlik
Copy link
Member

MichalPavlik commented Jun 21, 2023

LGTM

@baronfel
Copy link
Member Author

baronfel commented Jun 21, 2023

Thanks for review @MichalPavlik - I'll do the docs update for this between now and the preview6 release in a few weeks.

@baronfel baronfel merged commit 2cf914e into dotnet:main Jun 21, 2023
@baronfel baronfel deleted the containers-default-to-latest branch June 21, 2023 14:53
@baronfel baronfel added the breaking-change Using this label will notify dotnet/compat and trigger a request to file a compat bug label Jul 26, 2023
@ghost
Copy link

ghost commented Jul 26, 2023 •
edited by baronfel
Loading

Added needs-breaking-change-doc-created label because this PR has the breaking-change label.

When you commit this breaking change:

  1. Create and link to this PR and the issue a matching issue in the dotnet/docs repo using the breaking change documentation template, then remove this needs-breaking-change-doc-created label.
  2. Ask a committer to mail the .NET Breaking Change Notification DL.

Tagging @dotnet/compat for awareness of the breaking change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MichalPavlik MichalPavlik MichalPavlik approved these changes

Assignees

No one assigned

Labels

Area-Containers Related to dotnet SDK containers functionality breaking-change Using this label will notify dotnet/compat and trigger a request to file a compat bug needs-breaking-change-doc-created

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Change default image tag from $(Version) to latest

2 participants

@baronfel @MichalPavlik