Fix output validation in LaunchesBrowserOnStart test#53498
Merged
tmat merged 1 commit intodotnet:release/10.0.3xxfrom Mar 18, 2026
Merged
Fix output validation in LaunchesBrowserOnStart test#53498tmat merged 1 commit intodotnet:release/10.0.3xxfrom
tmat merged 1 commit intodotnet:release/10.0.3xxfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates a flaky dotnet watch browser-launch unit test by removing reliance on a specific output ordering, aligning the assertions with other dotnet-watch.Tests patterns that wait for expected output to appear asynchronously.
Changes:
- Replace immediate output list assertions with
WaitUntilOutputContainsfor the app startup lines. - Replace
AssertOutputContainswithWaitUntilOutputContainsfor the “Launching browser” message to avoid races.
3 tasks
Member
Author
|
@DustinCampbell ptal |
DustinCampbell
approved these changes
Mar 18, 2026
This was referenced Mar 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove assumption on output ordering.