Use Combinatorial.MSTest for boolean DataRow tests in dotnet.Tests - #55015
Draft
Evangelink wants to merge 1 commit into
Draft
Use Combinatorial.MSTest for boolean DataRow tests in dotnet.Tests#55015Evangelink wants to merge 1 commit into
Evangelink wants to merge 1 commit into
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR replaces full boolean cartesian-product
[DataRow]sets in thedotnet.Testsproject with[CombinatorialData]fromCombinatorial.MSTest.What changed
[DataRow(true)]/[DataRow(false)](and multi-parameter boolean combinations) removed[CombinatorialData]attribute instead[CombinatorialData]generates the full cartesian product of allboolparameters automatically.csprojchanges —dotnet.Testsalready referencesCombinatorial.MSTestWhy
This is part of a per-project series to modernize boolean-parameter test data in the SDK repository.
[CombinatorialData]is more concise, less error-prone (no risk of missing a combination), and scales naturally when new parameters are added.Co-authored-by: Copilot 223556219+Copilot@users.noreply.github.com