Use Combinatorial.MSTest for boolean DataRow tests in Microsoft.NET.ToolPack.Tests - #55016
Draft
Evangelink wants to merge 1 commit into
Draft
Use Combinatorial.MSTest for boolean DataRow tests in Microsoft.NET.ToolPack.Tests#55016Evangelink wants to merge 1 commit into
Evangelink wants to merge 1 commit into
Conversation
…oolPack.Tests Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This is part of a per-project series replacing full boolean cartesian-product
[DataRow]sets with[CombinatorialData]from theCombinatorial.MSTestpackage.What changed
Microsoft.NET.ToolPack.Testshad their explicit boolean[DataRow(true)]/[DataRow(false)](or multi-bool combinations) replaced with a single[CombinatorialData]attribute.Microsoft.NET.ToolPack.Tests.csprojgains a newItemGroupwith:<PackageReference Include="Combinatorial.MSTest" /><Using Include="Combinatorial.MSTest" />(global using so no per-file import is needed)No behavior change
[CombinatorialData]generates the same test cases as the removed[DataRow]combinations — it enumerates all combinations of theboolparameters automatically, producing identical executed test cases.Co-authored-by: Copilot 223556219+Copilot@users.noreply.github.com