Use Combinatorial.MSTest for boolean DataRow tests in Microsoft.NET.Pack.Tests - #55018
Draft
Evangelink wants to merge 1 commit into
Draft
Use Combinatorial.MSTest for boolean DataRow tests in Microsoft.NET.Pack.Tests#55018Evangelink wants to merge 1 commit into
Evangelink wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces full boolean cartesian-product
[DataRow(true)]/[DataRow(false)]sets inMicrosoft.NET.Pack.Testswith the[CombinatorialData]attribute from theCombinatorial.MSTestpackage.What changed
GivenThatWeWantToPackAHelloWorldProject.cs: The methodIt_packs_with_release_if_PackRelease_property_setpreviously had two explicit[DataRow]attributes to cover bothtrueandfalsefor itsbool optedOutparameter. These are replaced with a single[CombinatorialData]attribute, which automatically generates all boolean combinations — identical executed test cases, zero behavioral change.Microsoft.NET.Pack.Tests.csproj: Added anItemGroupwith:<PackageReference Include="Combinatorial.MSTest" />— the package providing the attribute<Using Include="Combinatorial.MSTest" />— global using so the attribute is available without an explicitusingdirectiveWhy
Full boolean
[DataRow]expansions are mechanical boilerplate.[CombinatorialData]expresses the same intent more concisely and scales automatically when additional bool parameters are added.This is part of a per-project series applying the same mechanical transformation across the SDK test suite.
Co-authored-by: Copilot 223556219+Copilot@users.noreply.github.com