Migrate DefineStaticWebAssets to multithreaded task execution#55117
Merged
AlesProkop merged 4 commits intoJul 24, 2026
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR migrates DefineStaticWebAssets to MSBuild multithreaded task execution by routing all path resolution through TaskEnvironment.ProjectDirectory (instead of process CWD) and updating related Static Web Assets normalization + cache invalidation behavior.
Changes:
- Marked
DefineStaticWebAssetsas[MSBuildMultiThreadableTask]and addedIMultiThreadableTask/TaskEnvironmentplumbing for MT-safe path resolution. - Updated Static Web Asset normalization/file resolution APIs to accept a
TaskEnvironmentso relative paths resolve against the project directory. - Reworked cache manifest path absolutization and cache input hashing to avoid CWD-sensitive metadata, adding MT-focused test coverage.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| test/Microsoft.NET.Sdk.StaticWebAssets.Tests/StaticWebAssets/DefineStaticWebAssetsMultiThreadingTest.cs | Adds tests validating MT-safe resolution against TaskEnvironment.ProjectDirectory and cache invalidation under a decoy process CWD. |
| src/StaticWebAssetsSdk/Tasks/DefineStaticWebAssets.cs | Switches candidate identity/content-root handling to use TaskEnvironment and MT-safe file resolution. |
| src/StaticWebAssetsSdk/Tasks/DefineStaticWebAssets.Cache.cs | Absolutizes cache manifest path via TaskEnvironment and updates cache input hashing to be MT/CWD independent. |
| src/StaticWebAssetsSdk/Tasks/Data/StaticWebAsset.cs | Extends asset construction/normalization to accept TaskEnvironment (fallback preserved for existing callers). |
OvesN
reviewed
Jul 3, 2026
- Treat null/empty/whitespace CacheManifestPath uniformly as "no cache":
switch to IsNullOrWhiteSpace and base the no-cache decision on the
normalized value, so a blank path never reaches GetAbsolutePath (which
throws) nor File.OpenWrite("") when persisting the cache manifest.
- Rename CacheInvalidatesRelativeCandidateWhenProjectFileChanges to
...WhenAssetFileChanges: the test mutates the candidate asset file's
contents/length, not a project file.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
jankratochvilcz
left a comment
jankratochvilcz
left a comment
Contributor
There was a problem hiding this comment.
Automated MSBuild MT-migration + expert review. The migration itself is complete and correct — all CWD-dependent path resolution now flows through TaskEnvironment, and the cache-key change (dropping well-known %(FullPath)/%(ModifiedTime) in favor of task-computed full paths + Length + LastWriteTimeUtc.Ticks) is a genuine correctness improvement. No blocking issues. A few non-blocking suggestions inline.
jankratochvilcz
approved these changes
Jul 8, 2026
OvesN
requested changes
Jul 21, 2026
OvesN
left a comment
OvesN
left a comment
Contributor
There was a problem hiding this comment.
PR looks good, but I am not sure if all changes in cache-logic are necessary
OvesN
approved these changes
Jul 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: dotnet/msbuild#14040
Context
DefineStaticWebAssetsnow participates in MSBuild multithreaded task execution. Relative candidate paths, content roots, cache manifest paths, and cache input keys must resolve againstTaskEnvironment.ProjectDirectoryinstead of the process current directory.Changes Made
[MSBuildMultiThreadableTask],IMultiThreadableTask, andTaskEnvironmentsupport toDefineStaticWebAssets.TaskEnvironmentthroughStaticWebAsset.FromProperties, normalization, file resolution, and related content-root handling.CacheManifestPathrelative toTaskEnvironment.ProjectDirectory.DefineStaticWebAssetscache input hashing to avoid CWD-sensitiveFullPathandModifiedTimemetadata, hashing MT-safe candidate paths and file state instead.DefineStaticWebAssetsMultiThreadingTestcoverage for relative candidate/content-root resolution and cache invalidation under a decoy process CWD.Testing
dotnet build src/StaticWebAssetsSdk/Tasks/Microsoft.NET.Sdk.StaticWebAssets.Tasks.csproj— passed fornet11.0andnet472.dotnet test test/Microsoft.NET.Sdk.StaticWebAssets.Tests/Microsoft.NET.Sdk.StaticWebAssets.Tests.csproj --filter "FullyQualifiedName~DefineStaticWebAssetsMultiThreadingTest"— passed, 2 tests.