Skip to content

Sign Microsoft.DotNet.HotReload.WebAssembly.Browser.lib.module.js - #55317

Merged
lewing merged 1 commit into
release/10.0.1xxfrom
akoeplinger-patch-1
Jul 16, 2026
Merged

Sign Microsoft.DotNet.HotReload.WebAssembly.Browser.lib.module.js#55317
lewing merged 1 commit into
release/10.0.1xxfrom
akoeplinger-patch-1

Conversation

@akoeplinger

Copy link
Copy Markdown
Member

This file is not user-modifiable so we can sign it.

Contributes to https://dev.azure.com/devdiv/DevDiv/_workitems/edit/2994765

Copilot AI review requested due to automatic review settings July 16, 2026 11:23
@akoeplinger
akoeplinger requested a review from lewing July 16, 2026 11:23
@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 1 pipeline(s).
2 pipeline(s) were filtered out due to trigger conditions.
There may be pipelines that require an authorized user to comment /azp run to run.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the SDK signing configuration to explicitly sign the Hot Reload WebAssembly browser JS module, while continuing to opt out of signing most .js files by default.

Changes:

  • Adjusts the .js signing rationale comment to reflect current sourcing/signing expectations.
  • Adds an explicit FileSignInfo entry to sign Microsoft.DotNet.HotReload.WebAssembly.Browser.lib.module.js with MicrosoftDotNet500.

@akoeplinger
akoeplinger requested a review from marcpopMSFT July 16, 2026 12:08
@akoeplinger

Copy link
Copy Markdown
Member Author

Infrastructure change, tell mode, applying Servicing-approved.

@lewing
lewing merged commit a5edf54 into release/10.0.1xx Jul 16, 2026
32 checks passed
@lewing
lewing deleted the akoeplinger-patch-1 branch July 16, 2026 17:34
@dotnet-milestone-bot dotnet-milestone-bot Bot added this to the 11.0-rc1 milestone Aug 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants