Make DOTNET_CLI_USE_MSBUILD_SERVER=false authoritative opt-out#55393
Merged
Conversation
|
Azure Pipelines: 3 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Co-authored-by: JanProvaznik <25267098+JanProvaznik@users.noreply.github.com>
Co-authored-by: JanProvaznik <25267098+JanProvaznik@users.noreply.github.com>
Co-authored-by: JanProvaznik <25267098+JanProvaznik@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix DOTNET_CLI_USE_MSBUILD_SERVER for /mt option
Make DOTNET_CLI_USE_MSBUILD_SERVER=false authoritative
Jul 21, 2026
JanProvaznik
approved these changes
Jul 21, 2026
|
Azure Pipelines: Successfully started running 1 pipeline(s). 2 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR makes DOTNET_CLI_USE_MSBUILD_SERVER=false an authoritative opt-out by ensuring the CLI forwards an explicit MSBUILDUSESERVER=0 when the user hasn’t explicitly set MSBUILDUSESERVER, preventing implicit server enablement via /mt, response files, or MSBUILDFORCEMULTITHREADED.
Changes:
- Change MSBuild forwarding to set
MSBUILDUSESERVERto1or0based onDOTNET_CLI_USE_MSBUILD_SERVERwhenMSBUILDUSESERVERis not already set. - Evaluate
DOTNET_CLI_USE_MSBUILD_SERVERper forwarding-app instance (not once at type initialization). - Add unit tests covering the interaction between
DOTNET_CLI_USE_MSBUILD_SERVERand explicitMSBUILDUSESERVERvalues.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/Cli/Microsoft.DotNet.Cli.Utils/MSBuildForwardingAppWithoutLogging.cs | Sets MSBUILDUSESERVER based on DOTNET_CLI_USE_MSBUILD_SERVER unless user explicitly sets MSBUILDUSESERVER; evaluates setting per invocation. |
| test/dotnet.Tests/CommandTests/MSBuild/GivenMsbuildForwardingApp.cs | Adds tests validating forwarding behavior for unset/explicit MSBUILDUSESERVER when CLI setting disables the server. |
Co-authored-by: JanProvaznik <25267098+JanProvaznik@users.noreply.github.com>
OvesN
approved these changes
Jul 21, 2026
This was referenced Jul 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DOTNET_CLI_USE_MSBUILD_SERVER=falsepreviously leftMSBUILDUSESERVERunset, allowing/mt, response files, orMSBUILDFORCEMULTITHREADED=1to implicitly enable the MSBuild server.Server selection
MSBUILDUSESERVER=0when the CLI server setting is disabled.MSBUILDUSESERVERvalues.Coverage
MSBUILDUSESERVERcases.