Enable method-level parallelism for TemplateEngine CLI tests - #55631
Merged
Conversation
Use a resource lock for the process-global Reporter and restore its previous value after each test. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 9db673a8-46cf-472d-8ba3-d4fc22d8dc16
|
Azure Pipelines: Successfully started running 1 pipeline(s). 2 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR enables method-level MSTest parallel execution for Microsoft.TemplateEngine.Cli.UnitTests and adjusts a known non-parallel-safe test class to avoid cross-test interference by serializing access to a process-global Reporter and restoring its original state after each test.
Changes:
- Enabled MSTest method-level parallelization for
Microsoft.TemplateEngine.Cli.UnitTests. - Replaced broad serialization with a targeted
[ResourceLock]forAddJsonPropertyPostActionTests. - Restored
Reporter.Errorafter each test to avoid leaking global state between tests.
Show a summary per file
| File | Description |
|---|---|
| test/Microsoft.TemplateEngine.Cli.UnitTests/PostActionTests/AddJsonPropertyPostActionTests.cs | Serializes tests that mutate Reporter and restores Reporter.Error after each test run. |
| test/Microsoft.TemplateEngine.Cli.UnitTests/Microsoft.TemplateEngine.Cli.UnitTests.csproj | Opts this test project into MSTest method-level parallelization. |
Copilot's findings
- Files reviewed: 2/2 changed files
- Comments generated: 1
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 9db673a8-46cf-472d-8ba3-d4fc22d8dc16
YuliiaKovalova
approved these changes
Aug 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Microsoft.TemplateEngine.Cli.UnitTestsinto MSTest method-level parallelizationAddJsonPropertyPostActionTestswith a namedResourceLockReporter.Errorvalue after each testValidation
Microsoft.TemplateEngine.Cli.UnitTests