Make target-pack ILAsm builds deterministic in BuildIlFile - #1663
Merged
Conversation
Agent-Logs-Url: https://github.com/dotnet/source-build-assets/sessions/3766ce1d-bbd0-4844-a5e5-3743480e5a8e Co-authored-by: mthalman <15789599+mthalman@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix ilasm invocation to include -deterministic flag
Make target-pack ILAsm builds deterministic in May 15, 2026
BuildIlFile
mthalman
approved these changes
May 15, 2026
mthalman
marked this pull request as ready for review
May 15, 2026 13:07
mthalman
enabled auto-merge (squash)
May 15, 2026 13:07
Member
|
I tested this locally myself. It does wonders. For me, the html-diff-render (without any exclusions/filtering) is down from 4.36 MB to 376KB. A 91% reduction. |
MichaelSimons
approved these changes
May 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
src/targetPacks/Directory.Build.targetsassembled.ilfiles without deterministic mode, producing non-reproducible PE timestamps/MVIDs for targeting-pack reference assemblies and causing downstream reproducibility drift. This update enables deterministic ILAsm output at the source.Build target update
BuildIlFileinsrc/targetPacks/Directory.Build.targetsto pass-deterministictoilasm.Reproducibility impact
.ilsources are deterministic.