Return to building core runtime as non-portable and allow different portability in ASP.NET and core runtime#1221
Merged
Merged
Conversation
crummel
requested review from
JunTaoLuo,
adaggarwal,
dseefeld,
ericstj and
nguerrera
September 10, 2019 16:49
JunTaoLuo
approved these changes
Sep 10, 2019
JunTaoLuo
left a comment
JunTaoLuo
left a comment
There was a problem hiding this comment.
+1 for keeping AspNetCore portable 🎉
dseefeld
approved these changes
Sep 10, 2019
nguerrera
reviewed
Sep 10, 2019
nguerrera
approved these changes
Sep 10, 2019
Contributor
Author
|
cc @ericstj just if you want to take a look and make sure there's nothing that'll bite us here. |
Member
|
Looks ok to me. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So far I've only tested the default non-portable build on my Fedora 31 machine, but that builds and smoke-tests. I'll work on testing additional configurations.