Refresh stale index overwrite chrome for new SourceBrowser#265
Conversation
The `overwrite/` files were authored against the pre-dotnet#264 SourceBrowser and were copied over the freshly generated index at build time, shadowing the new chrome both locally and in blob storage. This left source.dot.net serving old styles.css, header.html, overview.html, and an empty SolutionExplorer. Remove the three stale copies so the new SourceBrowser output is used, and refresh header.html onto the new base (restoring the meta tags and mobile pane toggle) while keeping the `.NET Source Browser` branding. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
|
@akoeplinger, @jeffhandley. The change otherwise went through and is working, but it turns out Confirmed that the customizations that had been made are no longer relevant for the deleted files and merged in the missing changes from the ones that still were relevant |
jeffhandley
left a comment
There was a problem hiding this comment.
Thanks for figuring this out!
There was a problem hiding this comment.
Pull request overview
Removes stale “overwrite” chrome assets that were shadowing the newly generated SourceBrowser UI during index builds, and refreshes the remaining override (header.html) to match the new base header while keeping the “.NET Source Browser” branding.
Changes:
- Delete stale override assets (
styles.css,overview.html,SolutionExplorer.html) so the generated/base chrome is served. - Update
overwrite/index/header.htmlto include the base header’smetatags and mobilepaneTogglesupport while retaining “.NET Source Browser” text.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/index/overwrite/wwwroot/styles.css | Removed stale overridden stylesheet so the current generated/base styling is used. |
| src/index/overwrite/index/overview.html | Removed stale overridden overview page so the stamped/generated overview is used. |
| src/index/overwrite/index/SolutionExplorer.html | Removed empty Solution Explorer override so the generated tree page is served. |
| src/index/overwrite/index/header.html | Rebased override on the new base header (meta tags + mobile pane toggle) while keeping .NET branding. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
The
src/index/overwrite/files were authored against the pre-#264 SourceBrowser and are copied over the freshly generated index at build time (index.projBuildIndex), so they shadow the new chrome both in the locally-served static files and in the copies uploaded to blob storage. After #264 deployed the new SourceBrowser, source.dot.net kept serving the oldstyles.css(28,429 B vs the new 45,108 B), oldheader.html/overview.html, and the emptySolutionExplorer.htmlplaceholder in place of the real tree -- which is why the site looked broken while https://source.terrafx.dev (running the un-overwritten chrome) rendered correctly.Every broken asset matched the checked-in overwrite byte-for-byte, and all were freshly re-uploaded to blob on the last run, so this was stale build input rather than a CDN/caching issue.
overwrite/wwwroot/styles.css-- a stale copy (only ever relocated, never customized); the new basestyles.cssis now used.overwrite/index/overview.html-- the new base is already.NET-branded, feature-complete, and gets$(IndexRunDate)/$(ProjectCount)/$(AssemblyCount)/$(SourceBrowserVersion)stamped byHtmlGenerator.overwrite/index/SolutionExplorer.html-- the empty override from Override the solution explorer with an empty one #18 is no longer wanted now that the Solution Explorer supports repo filtering; the generated tree is served instead.overwrite/index/header.htmlonto the new base, restoring themetacharset/viewport tags and the mobilepaneToggle, while keeping the.NET Source Browserbranding.Web.configandAffiliateLinks.txtare unchanged (the latter is still consumed bySourceIndexServer).Note:
header.htmlremains the one drift-prone override -- a future base header change will silently re-break it, which is exactly this bug's failure mode. Longer term the.NET Source Browserbranding would be better carried in the SourceBrowser base so no overwrite is needed.