Skip to content

Conversation

@Thaina
Copy link
Contributor

@Thaina Thaina commented Dec 23, 2016

Add jsonValidation with prototyped omnisharp

Add jsonValidation with prototyped omnisharp
@DustinCampbell
Copy link
Member

@Thaina: Where did this schema come from? Did you create it from scratch? Could you contribute it to https://github.com/OmniSharp/omnisharp-roslyn?

cc @filipw, @david-driscoll?

@Thaina
Copy link
Contributor Author

Thaina commented Jan 27, 2017

I use some tool that automatically generate schema from default json. I pick default formatting from some omnisharp repo

@filipw
Copy link
Contributor

filipw commented Jan 27, 2017

it's from here SchemaStore/schemastore#260

@DustinCampbell
Copy link
Member

Shouldn't we add this to the omnisharp-roslyn repo so we can keep it up-to-date?

@filipw
Copy link
Contributor

filipw commented Jan 27, 2017

It could even be generated dynamically with JSON.NET based on the object definitions at build time

@filipw
Copy link
Contributor

filipw commented Jan 27, 2017

added OmniSharp/omnisharp-roslyn#733

@DustinCampbell
Copy link
Member

Thanks!

@DustinCampbell
Copy link
Member

Now that we've got that out of the way... @Thaina, could you use spaces rather than tabs so that your change matches the rest of the file?

@DustinCampbell
Copy link
Member

Again, please make it looks like the rest of the file. You've indented too far. 😄

Sorry for being pedantic. 😄

Copy link
Member

@DustinCampbell DustinCampbell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much better. Thank you for being patient!

@DustinCampbell DustinCampbell merged commit 2403096 into dotnet:master Jan 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants