Skip to content

Fix several issues with diagnostics #592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 20, 2016
Merged

Fix several issues with diagnostics #592

merged 1 commit into from
Jul 20, 2016

Conversation

@DustinCampbell
Copy link
Member

@DustinCampbell DustinCampbell commented Jul 20, 2016 •
edited
Loading

Fixes #447 and #587

  1. The diagnostics provider won't refresh diagnostics while the OmniSharp server is restoring packages. Instead, it waits until it receives an event from OmniSharp afterward. However, that event was only expecting the old DNX protocol, so the diagnostics provider never automatically updated after packages were restored. This change gets rid of the DNX protocol and changes the diagnostic provider to look for .NET Core projects.
  2. Hidden diagnostics should have DiagnosticSeverity.Info rather DiagnosticSeverity.Warning.
  3. When the processing all of the diagnostics (not just those for the current file), the previous diagnostics were not cleared out first. This resulted in new diagnostics being merged with old diagnostics, creating duplicates diagnostics. Now we clear the diagnostics for a file before adding new ones.

@DustinCampbell
Fix several issues with diagnostics
4d205e0 
1. The diagnostics provider won't refresh diagnostics while the OmniSharp server is restoring packages. Instead, it
   waits until it receives an event from OmniSharp afterward. However, that event was only expecting the old DNX
   protocol, so the diagnostics provider never automatically updated after packages were restored. This change gets
   rid of the DNX protocol and changes the diagnostic provider to look for .NET Core projects.

2. Hidden diagnostics should have DiagnosticSeverity.Info rather DiagnosticSeverity.Warning.

3. When the processing *all* of the diagnostics (not just those for the current file), the previous diagnostics were
   not cleared out first. This resulted in new diagnostics being merged with old diagnostics, creating duplicates
   diagnostics. Now we clear the diagnostics for a file before adding new ones.
@DustinCampbell DustinCampbell added this to the 1.3 milestone Jul 20, 2016
@DustinCampbell
Copy link
Member Author

DustinCampbell commented Jul 20, 2016

cc @gregg-miskelly, @chuckries, @caslan, @rajkumar42, though this is an area of the code base that you're probably not familiar with.

@DustinCampbell
Copy link
Member Author

DustinCampbell commented Jul 20, 2016

Merging this now so I can produce a new beta release with this change to allow users to try it out.

@DustinCampbell DustinCampbell merged commit f8b05c7 into dotnet:master Jul 20, 2016
@DustinCampbell DustinCampbell deleted the fix-diagnostics branch September 1, 2016 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

1.3

Development

Successfully merging this pull request may close these issues.

2 participants

@DustinCampbell @dnfclas