Skip to content

[main] Source code updates from dotnet/dotnet - #15025

Merged
dotnet-maestro[bot] merged 3 commits into
mainfrom
darc-main-27d48641-1bea-4984-8c45-a48aafe77695
Sep 3, 2026
Merged

[main] Source code updates from dotnet/dotnet#15025
dotnet-maestro[bot] merged 3 commits into
mainfrom
darc-main-27d48641-1bea-4984-8c45-a48aafe77695

Conversation

@dotnet-maestro

@dotnet-maestro dotnet-maestro Bot commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

Note

This is a codeflow update. It may contain both source code changes from
the VMR
as well as dependency updates. Learn more here.

This pull request brings the following source code changes

From https://github.com/dotnet/dotnet

Updated Dependencies

  • From 11.0.0-beta.26424.125 to 11.0.0-beta.26451.109
    • Microsoft.DotNet.Arcade.Sdk
    • Microsoft.DotNet.Build.Tasks.Templating
    • Microsoft.DotNet.CMake.Sdk
    • Microsoft.DotNet.GenFacades
    • Microsoft.DotNet.Helix.Sdk
    • Microsoft.DotNet.RemoteExecutor
    • Microsoft.DotNet.XUnitV3Extensions
  • From 11.0.0-rc.1.26424.125 to 11.0.0-rc.1.26451.109
    • Microsoft.NET.Sdk.IL
    • Microsoft.NETCore.App.Ref
    • Microsoft.NETCore.ILAsm
    • Microsoft.NETCore.ILDAsm
    • Microsoft.Win32.SystemEvents
    • runtime.win-x64.Microsoft.NETCore.ILAsm
    • runtime.win-x86.Microsoft.NETCore.ILAsm
    • System.CodeDom
    • System.Configuration.ConfigurationManager
    • System.Diagnostics.DiagnosticSource
    • System.Formats.Nrbf
    • System.IO.Hashing
    • System.Reflection.MetadataLoadContext
    • System.Resources.Extensions
    • System.Runtime.Serialization.Formatters
    • System.Text.Encodings.Web
    • System.Text.Json
    • System.Windows.Extensions

Associated changes in source repos

Diff the source with this PR branch
darc vmr diff --name-only https://github.com/dotnet/dotnet:f2b969981e123579eb8a779dc05aa8138569dff9..https://github.com/dotnet/winforms:darc-main-27d48641-1bea-4984-8c45-a48aafe77695
Microsoft Reviewers: Open in CodeFlow

Updated Dependencies:
Microsoft.DotNet.Arcade.Sdk, Microsoft.DotNet.Build.Tasks.Templating, Microsoft.DotNet.CMake.Sdk, Microsoft.DotNet.GenFacades, Microsoft.DotNet.Helix.Sdk, Microsoft.DotNet.RemoteExecutor, Microsoft.DotNet.XUnitV3Extensions (Version 11.0.0-beta.26424.125 -> 11.0.0-beta.26451.109)
Microsoft.NET.Sdk.IL, Microsoft.NETCore.App.Ref, Microsoft.NETCore.ILAsm, Microsoft.NETCore.ILDAsm, Microsoft.Win32.SystemEvents, runtime.win-x64.Microsoft.NETCore.ILAsm, System.CodeDom, System.Configuration.ConfigurationManager, System.Diagnostics.DiagnosticSource, System.Formats.Nrbf, System.IO.Hashing, System.Reflection.MetadataLoadContext, System.Resources.Extensions, System.Runtime.Serialization.Formatters, System.Text.Encodings.Web, System.Text.Json, System.Windows.Extensions, runtime.win-x86.Microsoft.NETCore.ILAsm (Version 11.0.0-rc.1.26424.125 -> 11.0.0-rc.1.26451.109)
[[ commit created by automation ]]
@dotnet-maestro

dotnet-maestro Bot commented Sep 2, 2026

Copy link
Copy Markdown
Contributor Author

@dotnet-maestro
dotnet-maestro Bot requested a review from a team as a code owner September 2, 2026 02:12

@dotnet-policy-service dotnet-policy-service Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Go, you big red fire engine!

@LeafShi1

LeafShi1 commented Sep 2, 2026

Copy link
Copy Markdown
Member

The build failed with System.TypeInitializationException : The type initializer for 'Coverlet.Core.Instrumentation.Tracker.Microsoft.Private.Windows.Polyfills.Tests_d6550c7c-fd38-4022-a909-2613cf55c4ed' threw an exception. ---- System.IO.FileNotFoundException : Could not load file or assembly 'System.Runtime, Version=8.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a' or one of its dependencies. The system cannot find the file specified.

@LeafShi1

LeafShi1 commented Sep 2, 2026

Copy link
Copy Markdown
Member

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 1 pipeline(s).

@Shyam-Gupta

Copy link
Copy Markdown
Member

The build failed with System.TypeInitializationException : The type initializer for 'Coverlet.Core.Instrumentation.Tracker.Microsoft.Private.Windows.Polyfills.Tests_d6550c7c-fd38-4022-a909-2613cf55c4ed' threw an exception. ---- System.IO.FileNotFoundException : Could not load file or assembly 'System.Runtime, Version=8.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a' or one of its dependencies. The system cannot find the file specified.

I have disabled code coverage for net481 project to fix this issue. With latest update, code coverage host is not able to load System.Runtime v8.

@codecov

codecov Bot commented Sep 3, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 37.24166%. Comparing base (1dfc02d) to head (b85cbad).
⚠️ Report is 190 commits behind head on main.

❗ There is a different number of reports uploaded between BASE (1dfc02d) and HEAD (b85cbad). Click for more details.

HEAD has 3 uploads less than BASE
Flag BASE (1dfc02d) HEAD (b85cbad)
Debug 3 2
production 2 1
integration 1 0
Additional details and impacted files
@@                 Coverage Diff                  @@
##                main      #15025          +/-   ##
====================================================
- Coverage   77.31435%   37.24166%   -40.07269%     
====================================================
  Files           3265         246        -3019     
  Lines         644447        9774      -634673     
  Branches       47631        1029       -46602     
====================================================
- Hits          498250        3640      -494610     
+ Misses        142509        5970      -136539     
+ Partials        3688         164        -3524     
Flag Coverage Δ
Debug 37.24166% <ø> (-40.07270%) ⬇️
integration ?
production 39.36526% <ø> (-12.91627%) ⬇️
test 20.64923% <ø> (-76.76994%) ⬇️
unit 39.36526% <ø> (-10.26895%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Shyam-Gupta

Copy link
Copy Markdown
Member

Issue: Debug/x64 PR builds fail at test execution, every test in net481 leg throwing:

TypeInitializationException : The type initializer for
'Coverlet.Core.Instrumentation.Tracker.Microsoft.Private.Windows.Polyfills.Tests_' threw an exception.
---- FileNotFoundException : Could not load file or assembly 'System.Runtime, Version=8.0.0.0'

Only this leg is affected because build-PR.yml enables Coverage solely for public Debug x64.

Root cause

Commit #14371 bumped CoverletMSBuildPackageVersion  6.0.0 → 8.0.0. Coverlet 8.0.0 picks its task assembly by MSBuild host, not target framework — under dotnet build it loads tasks\net8.0\coverlet.core.dll, which references System.Runtime 8.0.0.0. The instrumenter copies its tracker IL from that assembly into the assembly under test, so the tracker injected into our net481 test assembly carries a reference .NET Framework can't resolve.

Upstream bug, not intentional: coverlet#1818.

Temporary fix:

Disable code coverage for net481 target.

 Directory.Build.props :

false

Tests still build and run; only .NET Framework coverage collection is skipped. No real loss — that leg was producing a red build and zero valid data.

Change needed once coverlet fixes this

Every coverlet release after 6.x is still broken for .NET Framework (8.0.1 → no coverage reported, #1842; 10.0.1 → different TypeInitializationException , #2009). Wait for coverlet #1985 (silent zero coverage) and #2010 (10.0.1 tracker crash) to ship, then:

  1. Update CoverletMSBuildPackageVersion in eng/Versions.props .
  2. Delete the CollectCoverage override and its comment from Directory.Build.props .
  3. Confirm a net481 .coverage file is actually produced under artifacts\bin...\coverage\

cc: @KlausLoeffelmann. @mcastro-x

@Shyam-Gupta

Copy link
Copy Markdown
Member

Logged bug #15030 to track this issue.

@dotnet-maestro

dotnet-maestro Bot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor Author

Important

While this PR was open, the source repository has received code changes from this repository (an opposite codeflow merged).
To avoid complex conflicts, the codeflow cannot continue until this PR is closed or merged.

You can continue with one of the following options:

  • Ignore this and merge this PR as usual without waiting for the new changes.
    Once merged, Maestro will create a new codeflow PR with the new changes.
  • Close this PR and wait for Maestro to open a new one with old and new changes included.
    You will lose any manual changes made in this PR.
    You can also manually trigger the new codeflow right away by running:
    darc trigger-subscriptions --id 81d064a4-929c-4152-b746-ee3acc24b4ed
    
  • Force a codeflow into this PR at your own risk if you want the new changes.
    User commits made to this PR might be reverted.
    darc trigger-subscriptions --id 81d064a4-929c-4152-b746-ee3acc24b4ed --force
    

💡 You may consult the FAQ for more information or tag @dotnet/prodconsvcs for assistance.

@dotnet-maestro
dotnet-maestro Bot merged commit 9cf27ae into main Sep 3, 2026
14 checks passed
@dotnet-maestro
dotnet-maestro Bot deleted the darc-main-27d48641-1bea-4984-8c45-a48aafe77695 branch September 3, 2026 07:13
abineshPalanisamy pushed a commit to abineshPalanisamy/winforms that referenced this pull request Sep 3, 2026
[main] Source code updates from dotnet/dotnet


 - Disabiling code coverage for net481.

 - Updated comment.
@dotnet-milestone-bot dotnet-milestone-bot Bot added this to the 12.0-preview1 milestone Sep 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants