fix: DataBindings.Remove/Clear unsubscribe from the INotifyPropertyChanged.PropertyChanged event#1963
Merged
Conversation
…anged.PropertyChanged event A regression introduced in dotnet#854 that caused bindings in the middle object to remain after those were unwired in the target control. Fixes dotnet#1679 (cherry picked from commit e04cb68)
Codecov Report
@@ Coverage Diff @@
## master #1963 +/- ##
==================================================
- Coverage 27.29413% 27.2881% -0.00603%
==================================================
Files 869 869
Lines 266702 266706 +4
Branches 37907 37908 +1
==================================================
- Hits 72794 72779 -15
- Misses 188732 188758 +26
+ Partials 5176 5169 -7
|
RussKie
deleted the
fix_1679_DataBindings.Remove_unsubscribe_from_the_INotifyPropertyChanged.PropertyChanged_event
branch
ghost
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1679
(cherry picked from commit e04cb68)
A regression introduced in #854 that resulted in making use of target control owner's
BindingManagerBaseinstead of using the target control's own.Proposed changes
Customer Impact
Regression?
Risk
Test methodology
Microsoft Reviewers: Open in CodeFlow