Refactor BindToObject#854
Merged
Merged
Conversation
No cleanup performed here
This is duplicated in Binding
Contributor
|
@hughbe this looks good, do sny tests need to be changed or added? any additional verifs? |
Contributor
Author
|
@zsd4yr I'm happy with the current test coverage, especially once #867 is merged. We've got coverage for |
zsd4yr
approved these changes
May 10, 2019
RussKie
added a commit
to RussKie/winforms
that referenced
this pull request
Sep 13, 2019
…anged.PropertyChanged event A regression introduced in dotnet#854 that caused bindings in the middle object to remain after those were unwired in the target control. Fixes dotnet#1679
RussKie
added a commit
to RussKie/winforms
that referenced
this pull request
Sep 24, 2019
…anged.PropertyChanged event A regression introduced in dotnet#854 that caused bindings in the middle object to remain after those were unwired in the target control. Fixes dotnet#1679 (cherry picked from commit e04cb68)
ghost
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Essentially the
BindToObjectclass is strangely connected toBinding. It seems to be designed to be used separately, but this just causes confusion as there are two different sources of truth that need to be (and are) synchronised. We can avoid this byBindingand not exposingBindToObjectto anyone outside of theBindingClass(commit 1-3)BindToObjecttoBindingwhich has central ownership of these properties