Skip to content

Ensure the identity name is the same for C# and VB templates #946

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 13, 2019
Merged

Ensure the identity name is the same for C# and VB templates #946

merged 1 commit into from
Jun 13, 2019

Conversation

@jmarolf
Copy link
Contributor

@jmarolf jmarolf commented Jun 13, 2019

Having mismatched identities means that shim templates cannot be re-used across languages in VS

@jmarolf
Ensure the identity name is the same for C# and VB templates
49551d3 
Having mismatched identities means that shim templates cannot be re-used across languages in VS
@ghost ghost added the PR metadata: Label to tag PRs, to facilitate with triage label Jun 13, 2019
@ghost ghost requested review from rladuca, ryalanms, stevenbrix and vatsan-madhavan June 13, 2019 18:35
@jmarolf
Copy link
Contributor Author

jmarolf commented Jun 13, 2019

fixes AB#902637

@vatsan-madhavan vatsan-madhavan merged commit cf0bed3 into dotnet:master Jun 13, 2019
@peterhuene peterhuene mentioned this pull request Jun 17, 2019
Closed
vatsan-madhavan added a commit that referenced this pull request Jun 18, 2019
@vatsan-madhavan
Reverts "Ensure the identity name is the same for C# and VB templates (…
36705d7 
…#946)"

This reverts commit cf0bed3.

Fixes ‘Dotnet new‘ shows WPF template for VB only #987
@vatsan-madhavan vatsan-madhavan mentioned this pull request Jun 18, 2019
Merged
ghost pushed a commit that referenced this pull request Jun 18, 2019
@vatsan-madhavan
Reverts "Ensure the identity name is the same for C# and VB templates (…
c9bdfc0 
…#946)" (#993)

This reverts commit cf0bed3.

Fixes ‘Dotnet new‘ shows WPF template for VB only #987
@ghost ghost locked as resolved and limited conversation to collaborators Apr 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@vatsan-madhavan vatsan-madhavan vatsan-madhavan approved these changes

@rladuca rladuca Awaiting requested review from rladuca

@ryalanms ryalanms Awaiting requested review from ryalanms

@stevenbrix stevenbrix Awaiting requested review from stevenbrix

Assignees

No one assigned

Labels

PR metadata: Label to tag PRs, to facilitate with triage

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jmarolf @vatsan-madhavan